Do not send desktop notification if user has toggled off global deskt… #2055
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devketanpro
reviewed
Aug 8, 2024
| @@ -355,6 +355,10 @@ def send_assignment_notification(self, updates, original=None, force=False): | |||
| if assigned_to_user and get_user_notification_preferences(assigned_to_user, "assignments")["email"] is False: | |||
| return | |||
|
|
|||
| # No assignment desktop notification sent, if a user has disabled their global desktop notifications | |||
| if not assigned_to_user.get("user_preferences", {}).get("desktop:notification", {}).get("enabled", True): | |||
There was a problem hiding this comment.
If the user has an assignment mail toggle is on and desktop notification is off, so in this case nothing is going to happen, means user has not received any mail.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SDBELGA-818
Sending assignment desktop notifications should not be possible if the user has them toggled off in settings