Update with new superdesk content profile API #2089
Conversation
| @@ -20,6 +21,24 @@ const DEFAULT_PLANNING_SCHEMA = { | |||
| }; | |||
|
|
|||
| export class AddToPlanningController { | |||
| $scope: any; | |||
| notify: typeof superdeskApi['ui']['notify']; | |||
There was a problem hiding this comment.
It's not correct to specify this type. You should not make assumptions on what superdesk API is using under the hood as implementation. It should be possible to easily change it without breaking anything.
|
Regarding checklist, if it doesn't apply to the PR (i.e. no lodash usages), mark as done. I'd like to quickly see whether there are any guidelines that do apply, but were not implemented. |
I went over the checklist, and I checked all the boxes that are done by me, thus apply to the PR 
|
| .then((newsItem: IArticle) => { | ||
| const contentProfile = superdeskApi.entities.contentProfile.get(newsItem.profile); | ||
|
|
||
| return Promise.resolve({ |
There was a problem hiding this comment.
no need for Promise.resolve here. You should return the object directly. Since it's inside a .then it's a promise already
SDCP-838
Front-end checklist
memoorPureComponentto define new React components (and updates existing usages in modified code segments)lodash.getwith optional chaining and nullish coalescing for modified code segmentssuperdeskApi)superdesk-ui-frameworkandsuperdeskApiwhen possible instead of using ones defined in this repository.planningApiwhere it is possible to usesuperdeskApiplanningApi)