[CoreBundle] Add option to link assets from current theme through controller #203
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahilles107
force-pushed
the
SWP-327_theme_assets_heler_controller
branch
from
4a9624b to
cf5da4a
Compare
Current coverage is 46.08% (diff: 100%)@@ master #203 diff @@
==========================================
Files 505 505
Lines 12698 12698
Methods 2348 2348
Messages 0 0
Branches 0 0
==========================================
Hits 5852 5852
Misses 6846 6846
Partials 0 0
|
takeit
suggested changes
Dec 19, 2016
|
|
||
| .. code-block:: twig | ||
|
|
||
| /public/{fileName}.{fileExtension} |
There was a problem hiding this comment.
shouldn't this example be /{fileName}.{fileExtension} according to its description?
| use Symfony\Component\HttpFoundation\ResponseHeaderBag; | ||
| use Symfony\Component\HttpKernel\Exception\NotFoundHttpException; | ||
|
|
||
| class StaticThemeAssetsController extends Controller |
takeit
reviewed
Dec 19, 2016
| Load Service Worker files (from domain root level) | ||
| `````````````````````````````````````````````````` | ||
|
|
||
| If You want to use service worker or manifest file (it must be placed in root level) then you can use this url: |
There was a problem hiding this comment.
I would link to service worker definition here
…troller (without knowing current organization or tenant codes)
ahilles107
force-pushed
the
SWP-327_theme_assets_heler_controller
branch
from
cf5da4a to
023c1b7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(without knowing current organization or tenant codes)