Rely on evelovedfrom property instead of a slug #270
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
takeit
commented
Feb 22, 2017
takeit
commented
| Q | A |
|---|---|
| Bug fix? | yes |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Tests pass? | yes |
| Changelog update required | yes |
| Fixed tickets | SWP-589 |
| License | AGPLv3 |
ahilles107
approved these changes
Feb 22, 2017
ahilles107
reviewed
Feb 23, 2017
| $this->addSql('ALTER TABLE swp_item ADD evolved_from VARCHAR(255) DEFAULT NULL'); | ||
| $this->addSql('ALTER TABLE swp_package ADD evolved_from VARCHAR(255) DEFAULT NULL'); | ||
| $this->addSql('ALTER TABLE swp_article ADD code VARCHAR(255) DEFAULT NULL'); | ||
| $this->addSql('UPDATE swp_article SET code = md5(random()::text)'); |
There was a problem hiding this comment.
It creates issues, after that you can't update article as is no longer recognized and Publisher want's to create new one with this same slug (and it throws exception). As in real article createion we use guuid here initially then also here we should fill it with guid.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.