bevy_pbr: Fix frustum plane construction

The normals should be unit normals, not the entire normal_d.
superdump · Feb 24, 2022 · 34d134d · 34d134d
1 parent 3493bb7
commit 34d134d
Showing 1 changed file with 5 additions and 6 deletions.
diff --git a/crates/bevy_render/src/primitives/mod.rs b/crates/bevy_render/src/primitives/mod.rs
@@ -1,5 +1,5 @@
 use bevy_ecs::{component::Component, reflect::ReflectComponent};
-use bevy_math::{Mat4, Vec3, Vec3A, Vec4};
+use bevy_math::{Mat4, Vec3, Vec3A, Vec4, Vec4Swizzles};
 use bevy_reflect::Reflect;
 
 /// An Axis-Aligned Bounding Box
@@ -112,13 +112,12 @@ impl Frustum {
                 row3 + row
             } else {
                 row3 - row
-            }
-            .normalize();
+            };
+            plane.normal_d *= 1.0 / plane.normal_d.xyz().length();
         }
         let far_center = *view_translation - far * *view_backward;
-        planes[5].normal_d = view_backward
-            .extend(-view_backward.dot(far_center))
-            .normalize();
+        planes[5].normal_d = view_backward.extend(-view_backward.dot(far_center));
+        planes[5].normal_d *= 1.0 / planes[5].normal_d.xyz().length();
         Self { planes }
     }