Skip to content

Commit

Permalink
Update changelog
Browse files Browse the repository at this point in the history
  • Loading branch information
kartik4949 authored and blythed committed Jul 2, 2024
1 parent 39d851e commit 8d74d41
Show file tree
Hide file tree
Showing 4 changed files with 7 additions and 5 deletions.
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -83,6 +83,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
- Add `Application` and `Template` support to build reusable apps
- Add pretty-print to `Component.info`
- `Model`
- 'Add pluggable compute backend via config'

#### Bug Fixes

Expand Down
3 changes: 2 additions & 1 deletion superduperdb/base/build.py
Original file line number Diff line number Diff line change
Expand Up @@ -140,7 +140,8 @@ def build_compute(compute):
:param compute: Compute uri.
"""
logging.info("Connecting to compute client:", compute)
spath = compute._path.split('.')
path = compute._path or 'superduperdb.backends.local.compute.LocalComputeBackend'
spath = path.split('.')
path, cls = '.'.join(spath[:-1]), spath[-1]

module = importlib.import_module(path)
Expand Down
4 changes: 2 additions & 2 deletions superduperdb/jobs/job.py
Original file line number Diff line number Diff line change
Expand Up @@ -311,7 +311,7 @@ def remote_job(identifier, dependencies=(), compute_kwargs: t.Union[str, t.Dict]
if isinstance(compute_kwargs, str) and compute_kwargs:
compute_kwargs = json.loads(compute_kwargs)

compute = build_compute(CFG.cluster.compute.uri)
compute = build_compute(CFG.cluster.compute)

assert compute.remote is True, "Compute is not a distributed backend type."

Expand All @@ -332,7 +332,7 @@ def remote_task(identifier, dependencies=()):

# TODO: Make this run a predict job with multiple
# chunks as tasks.
db = build_datalayer(CFG, cluster__compute__uri=None)
db = build_datalayer(CFG, cluster__compute___path=None)

info = db.metadata.get_job(identifier)

Expand Down
4 changes: 2 additions & 2 deletions superduperdb/jobs/tasks.py
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ def method_job(
# Set the compute as local since otherwise a new
# Ray cluster would be created inside the job
if db is None:
db = build_datalayer(cfg=cfg, cluster__compute__uri=None)
db = build_datalayer(cfg=cfg, cluster__compute___path=None)

component = db.load(type_id, identifier)
# TODO: Move the unpack method to the better place
Expand Down Expand Up @@ -92,7 +92,7 @@ def callable_job(
# Set the compute as local since otherwise a new
# Ray cluster would be created inside the job
if db is None:
db = build_datalayer(cfg=cfg, cluster__compute__uri=None)
db = build_datalayer(cfg=cfg, cluster__compute___path=None)

db.metadata.update_job(job_id, 'status', 'running')
output = None
Expand Down

0 comments on commit 8d74d41

Please sign in to comment.