Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop no common options #2322

Merged
merged 6 commits into from
Jul 18, 2024
Merged

Drop no common options #2322

merged 6 commits into from
Jul 18, 2024

Conversation

EdwardLi-coder
Copy link
Contributor

@EdwardLi-coder EdwardLi-coder commented Jul 17, 2024 •
edited
Loading

Description

some linting and small refactors.

Related Issues

Checklist

  • Is this code covered by new or existing unit tests or integration tests?
  • Did you run make unit_testing and make integration-testing successfully?
  • Do new classes, functions, methods and parameters all have docstrings?
  • Were existing docstrings updated, if necessary?
  • Was external documentation updated, if necessary?

Additional Notes or Comments

@EdwardLi-coder
Copy link
Contributor Author

Hey @blythed. I want to resolve this issue, but I’m not sure about the details of what I need to do. Can you give me some suggestions on how to address this issue more effectively?

@blythed
Copy link
Collaborator

blythed commented Jul 18, 2024 •
edited
Loading

Hi @EdwardLi-coder thanks for contributing. I don't see how the PR relates to the description you gave. Please explain.

@EdwardLi-coder
Copy link
Contributor Author

Hi @EdwardLi-coder thanks for contributing. I don't see how the PR relates to the description you gave. Please explain.

The issue name is [SIMPLIFY-2]: Drop options which are not common between MongoDB and Ibis. I reviewed the project files related to MongoDB and Ibis to identify the differences between them. I found that the ChangeStream function might need to be deleted, but I’m not sure if this is correct or if more needs to be done. While reviewing and running make lint-and-type-check, I removed some warnings and updated some outdated annotations. If you think these changes are unnecessary, I can remove them. I understand these changes are not directly related to this issue; I only wanted to improve the project.

blythed
blythed reviewed Jul 18, 2024
View reviewed changes
CHANGELOG.md Outdated
@@ -51,6 +51,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
- Fix the dependency error in copy_vectors within vector_index.
- Fix Template substitutions
- Fix remove un_use _import function
- Fix Drop options which are not in common MongoDB vs. Ibis
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove this and change the description of the PR that this is some linting and small refactors.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

@blythed blythed merged commit b73d6a8 into superduper-io:main Jul 18, 2024
3 checks passed
@EdwardLi-coder EdwardLi-coder deleted the drop_no_common_options branch July 18, 2024 13:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@blythed blythed blythed left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@EdwardLi-coder @blythed