add component.Info() support lists #2338
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kartik4949
requested changes
Jul 23, 2024
superduper/misc/special_dicts.py
Outdated
| handled_list = [] | ||
| for item in lst: | ||
| if isinstance(item, Leaf): | ||
| if len(str(item)) > 50: |
There was a problem hiding this comment.
since you are already making changes to the file, lets make 50 value a const var.
superduper/misc/special_dicts.py
Outdated
| @@ -418,6 +432,8 @@ def _component_info(obj): | |||
| value = str(value)[:50] + "..." | |||
| else: | |||
| value = str(value) | |||
| elif isinstance(value, list): | |||
There was a problem hiding this comment.
lets add test for tuple as well
elif isinstance(value, (tuple, list))
superduper/misc/special_dicts.py
Outdated
| handled_list.append(str(item)[:50] + "...") | ||
| else: | ||
| handled_list.append(str(item)) | ||
| elif isinstance(item, list): |
There was a problem hiding this comment.
you can test for tuple as well
|
Hi @kartik4949 ,I have changed it.please review it.Thank you. |
kartik4949
approved these changes
Jul 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
add component.Info() support lists
Related Issues
[BUG] Component.info() doesn't go inside lists #2234
Checklist
make unit_testingandmake integration-testingsuccessfully?Additional Notes or Comments