Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make 'create a table' compulsory #2339

Merged
merged 1 commit into from
Jul 23, 2024
Merged

Make 'create a table' compulsory #2339

merged 1 commit into from
Jul 23, 2024

Conversation

jieguangzhou
Copy link
Collaborator

Description

Related Issues

Checklist

  • Is this code covered by new or existing unit tests or integration tests?
  • Did you run make unit_testing and make integration-testing successfully?
  • Do new classes, functions, methods and parameters all have docstrings?
  • Were existing docstrings updated, if necessary?
  • Was external documentation updated, if necessary?

Additional Notes or Comments

@jieguangzhou jieguangzhou linked an issue Jul 23, 2024 that may be closed by this pull request
[SIMPLIFY-2] Make "create a table" compulsory (but supported by auto-schema) #2300
Closed
kartik4949
kartik4949 reviewed Jul 23, 2024
View reviewed changes
superduper/base/datalayer.py
@@ -419,6 +418,20 @@ def _insert(

return inserted_ids, None

def _auto_create_table(self, table_name, documents):
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if create table is compulsory
why auto create?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After modification, it has become two choices:

  1. Explicitly manually creating the table
  2. Implicitly automatically creating the table

In both cases, the table will be created regardless, and it is unrelated to the backend.

@jieguangzhou jieguangzhou mentioned this pull request Jul 23, 2024
Merged
5 tasks
@kartik4949 kartik4949 merged commit d854545 into superduper-io:main Jul 23, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kartik4949 kartik4949 kartik4949 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[SIMPLIFY-2] Make "create a table" compulsory (but supported by auto-schema)
2 participants
@jieguangzhou @kartik4949