Testing utils for plugins #2374
Merged
+1,276
−619
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jieguangzhou
force-pushed
the
feat/test-utils
branch
from
4988bec to
371d393
Compare
jieguangzhou
force-pushed
the
feat/test-utils
branch
from
371d393 to
ff6bd5c
Compare
jieguangzhou
force-pushed
the
feat/test-utils
branch
from
ff6bd5c to
5874fee
Compare
jieguangzhou
force-pushed
the
feat/test-utils
branch
2 times, most recently
from
df0e08a to
4de19fd
Compare
jieguangzhou
force-pushed
the
feat/test-utils
branch
from
4de19fd to
2effd46
Compare
jieguangzhou
commented
Aug 7, 2024
Comment on lines
+660
to
+710
| def _execute_pre_like(self, parent): | ||
| assert self.parts[0][0] == 'like' | ||
| assert self.parts[1][0] in ['find', 'find_one', 'select'] | ||
|
|
||
| similar_ids, similar_scores = self._prepare_pre_like(parent) | ||
|
|
||
| query = self[1:] | ||
| query = query.filter(query[self.primary_id].isin(similar_ids)) | ||
| result = query.execute() | ||
| result.scores = similar_scores | ||
| return result | ||
|
|
||
| def _execute_post_like(self, parent): | ||
| assert self.parts[0][0] in { | ||
| 'find', | ||
| 'select', | ||
| }, "Post like query must start with find/select" | ||
| if self.parts[-1][0] != 'like': | ||
| raise ValueError('Post like query must end with like') | ||
| like_kwargs = self.parts[-1][2] | ||
| like_args = self.parts[-1][1] | ||
| assert 'vector_index' in like_kwargs | ||
|
|
||
| if not like_args and 'r' in like_kwargs: | ||
| like_args = (like_kwargs['r'],) | ||
|
|
||
| assert like_args | ||
|
|
||
| query = self[:-1] | ||
| result = list(query.execute()) | ||
| ids = [str(r[self.primary_id]) for r in query.execute()] | ||
|
|
||
| similar_ids, scores = self.db.select_nearest( | ||
| like=like_args[0], | ||
| ids=ids, | ||
| vector_index=like_kwargs.get('vector_index'), | ||
| n=like_kwargs.get('n', 100), | ||
| ) | ||
| scores = dict(zip(similar_ids, scores)) | ||
|
|
||
| result = [r for r in result if str(r[self.primary_id]) in similar_ids] | ||
|
|
||
| from superduper.base.cursor import SuperDuperCursor | ||
|
|
||
| cursor = SuperDuperCursor( | ||
| raw_cursor=result, | ||
| db=self.db, | ||
| id_field=self.primary_id, | ||
| ) | ||
| cursor.scores = scores | ||
| return cursor |
There was a problem hiding this comment.
All queries have the same logic regarding ‘like’.
jieguangzhou
force-pushed
the
feat/test-utils
branch
from
2effd46 to
0781c88
Compare
kartik4949
approved these changes
Aug 8, 2024
| assert artifact_store.exists("id") | ||
|
|
||
| # test get_bytes | ||
| assert artifact_store.get_bytes("id") == b"hello" |
| @@ -656,6 +657,58 @@ def table_or_collection(self): | |||
| """Return the table or collection to select from.""" | |||
| return type(self)(table=self.table, db=self.db) | |||
|
|
|||
| def _execute_pre_like(self, parent): | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related Issues
Checklist
make unit_testingandmake integration-testingsuccessfully?Additional Notes or Comments