Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix/links/docs #2375

Merged
merged 3 commits into from
Aug 6, 2024
Merged

Fix/links/docs #2375

merged 3 commits into from
Aug 6, 2024

Conversation

kartik4949
Copy link
Collaborator

@kartik4949 kartik4949 commented Aug 6, 2024 •
edited
Loading

Description

fix ##2373

Related Issues

Checklist

  • Is this code covered by new or existing unit tests or integration tests?
  • Did you run make unit_testing and make integration-testing successfully?
  • Do new classes, functions, methods and parameters all have docstrings?
  • Were existing docstrings updated, if necessary?
  • Was external documentation updated, if necessary?

Additional Notes or Comments

fazlulkarimweb
fazlulkarimweb approved these changes Aug 6, 2024
View reviewed changes
Copy link
Collaborator

@fazlulkarimweb fazlulkarimweb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM... NO error is showing

@fazlulkarimweb fazlulkarimweb merged commit c1aa94e into superduper-io:main Aug 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fazlulkarimweb fazlulkarimweb fazlulkarimweb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kartik4949 @fazlulkarimweb