-
Notifications
You must be signed in to change notification settings - Fork 469
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Qdrant vector search support #2428
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @Anush008 - thank-you for your work and this important contribution to the project!
My main concerns are around configuring the solution (in the config.py
module) and
also how we test this.
Could you add comments in the PR on how you tested this? Also, we should somehow test this in the CI too.
Hey @blythed. The implementation already undergoes the unit tests.. |
In-memory mode reference. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work!
@Anush008 could you get the CI passing? |
Haha. I assumed it was some flaky test. Updated the CHANGELOG. Should be good now. |
@blythed, could you please approve the CI to check? |
I am not sure if the failure is related to this PR. |
Thanks @Anush008 for your PR. This error usually occurs due to implicit type casting, such as using a It would be very helpful if you could identify where this type casting happens (e.g., in the arguments used when calling qdrant). If pinpointing the issue is not feasible, as a last resort, you can try increasing the type_ignore value in test/unittest/test_quality.py. Here's the link to the relevant line: superduper/test/unittest/test_quality.py Line 22 in 875ac4f
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pushed a fix. Should be green now. |
Description:
This PR adds support for Qdrant to be used for vector search.
Checklist
make unit_testing
andmake integration-testing
successfully?