Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the bug where shared artifacts are deleted #2446

Merged
merged 2 commits into from
Sep 11, 2024
Merged

Fix the bug where shared artifacts are deleted #2446

merged 2 commits into from
Sep 11, 2024

Conversation

jieguangzhou
Copy link
Collaborator

@jieguangzhou jieguangzhou commented Sep 9, 2024 •
edited
Loading

#2441

Description

Related Issues

Checklist

  • Is this code covered by new or existing unit tests or integration tests?
  • Did you run make unit_testing and make integration-testing successfully?
  • Do new classes, functions, methods and parameters all have docstrings?
  • Were existing docstrings updated, if necessary?
  • Was external documentation updated, if necessary?

Additional Notes or Comments

@jieguangzhou jieguangzhou changed the title Fix the bug where shared artifacts are deleted when removing a compon… Fix the bug where shared artifacts are deleted Sep 9, 2024
@jieguangzhou jieguangzhou force-pushed the feat/template-artifact branch 2 times, most recently from de9fbe2 to b81b8ec Compare September 9, 2024 14:44
@jieguangzhou jieguangzhou linked an issue Sep 9, 2024 that may be closed by this pull request
[BUG] Deleting a component deletes the artifacts of other components #2441
Closed
@jieguangzhou jieguangzhou force-pushed the feat/template-artifact branch from b81b8ec to f54726d Compare September 9, 2024 14:46
@jieguangzhou jieguangzhou marked this pull request as draft September 9, 2024 14:59
@jieguangzhou jieguangzhou force-pushed the feat/template-artifact branch from f54726d to 90a1cba Compare September 9, 2024 15:04
@jieguangzhou jieguangzhou marked this pull request as ready for review September 9, 2024 15:05
kartik4949
kartik4949 requested changes Sep 10, 2024
View reviewed changes
Copy link
Collaborator

@kartik4949 kartik4949 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good tome!

superduper/backends/base/metadata.py Outdated Show resolved Hide resolved
@jieguangzhou jieguangzhou merged commit 51bdf94 into superduper-io:main Sep 11, 2024
5 checks passed
This was referenced Sep 14, 2024
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kartik4949 kartik4949 kartik4949 approved these changes

@blythed blythed Awaiting requested review from blythed

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] Deleting a component deletes the artifacts of other components
2 participants
@jieguangzhou @kartik4949