fix: clean Qdrant collection name #2458
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Anush008
commented
Sep 16, 2024
| points = [] | ||
| for item in items: | ||
| vector = ( | ||
| item.vector.tolist() if hasattr(item.vector, "tolist") else item.vector |
There was a problem hiding this comment.
It turns out item.vector can be a regular list. For which, tolist() doesn't exist.
|
The failing CI seems unrelated. |
jieguangzhou
approved these changes
Sep 23, 2024
jieguangzhou
force-pushed
the
fix-qdrant
branch
from
73b406b to
8c71d95
Compare
@Anush008 Hey, Thank you for fixing it, I merged |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Qdrant doesn't allow certain special characters in the collection names. Hence this fix.