Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add select missing ids in mongodb plugin #2648

Merged
merged 1 commit into from
Nov 29, 2024

Conversation

kartik4949
Copy link
Collaborator

@kartik4949 kartik4949 commented Nov 26, 2024

Description

fix #2631

Related Issues

Checklist

  • Is this code covered by new or existing unit tests or integration tests?
  • Did you run make unit_testing and make integration-testing successfully?
  • Do new classes, functions, methods and parameters all have docstrings?
  • Were existing docstrings updated, if necessary?
  • Was external documentation updated, if necessary?

Additional Notes or Comments

@@ -269,3 +269,21 @@ def test_replace_one(db):
doc = db.execute(collection.find_one({'_id': r['_id']}))
print(doc['x'])
assert doc.unpack()['x'].tolist() == new_x.tolist()


def test_select_missing_ids(db):
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice.

Copy link
Collaborator

@blythed blythed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice fix. Please can you check the ibis implementation also?

Copy link
Collaborator

@blythed blythed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please check the ibis implementation also.

@kartik4949 kartik4949 force-pushed the fix/select_missing branch 3 times, most recently from 688cdfd to 9fdd567 Compare November 28, 2024 10:56
@kartik4949 kartik4949 merged commit 510226b into superduper-io:main Nov 29, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Select ids of missing outputs is broken and not used.
2 participants