Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add some features to the superduper agent #2684

Merged
merged 2 commits into from
Dec 13, 2024
Merged

Add some features to the superduper agent #2684

merged 2 commits into from
Dec 13, 2024

Conversation

jieguangzhou
Copy link
Collaborator

@jieguangzhou jieguangzhou commented Dec 11, 2024 •
edited
Loading

Description

  1. Support var:template_staged_file
  2. add Data Component
  3. Update crontab backend
  4. Fix some bugs related to Ibis data querying and insertion.

Related Issues

Checklist

  • Is this code covered by new or existing unit tests or integration tests?
  • Did you run make unit_testing and make integration-testing successfully?
  • Do new classes, functions, methods and parameters all have docstrings?
  • Were existing docstrings updated, if necessary?
  • Was external documentation updated, if necessary?

Additional Notes or Comments

@jieguangzhou jieguangzhou requested review from blythed and kartik4949 and removed request for blythed December 11, 2024 15:07
@jieguangzhou jieguangzhou changed the title Support <var:template_staged_file> and add Data Component Add some feature for superduper agent Dec 13, 2024
@jieguangzhou jieguangzhou changed the title Add some feature for superduper agent Add some features to the superduper agent Dec 13, 2024
blythed
blythed reviewed Dec 13, 2024
View reviewed changes
superduper/components/template.py
def _replace_stage_file(self, data):
if self.staged_file:
self.unpack()
data = _replace_variables(data, template_staged_file=self.staged_file)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's this?

@blythed
Copy link
Collaborator

blythed commented Dec 13, 2024

I don't understand the aim of each of these new components/ functions. Please describe.

blythed
blythed reviewed Dec 13, 2024
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
@jieguangzhou jieguangzhou merged commit 3849848 into superduper-io:main Dec 13, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@blythed blythed blythed approved these changes

@kartik4949 kartik4949 Awaiting requested review from kartik4949

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jieguangzhou @blythed