Notebook/fix vector search #448
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thejumpman2323
suggested changes
Jul 18, 2023
superduperdb/core/component.py
Outdated
| @@ -16,6 +16,15 @@ class Component(Serializable): | |||
|
|
|||
| variety: t.ClassVar[str] | |||
|
|
|||
| def init(self, db): | |||
superduperdb/core/model.py
Outdated
| @dc.dataclass | ||
| class Model(Component): | ||
| class Model(PredictMixin, Component): |
There was a problem hiding this comment.
Model(Component, PredictMixin)
| from superduperdb.encoders.torch.tensor import tensor | ||
|
|
||
| t = tensor(torch.float, shape=(64,)) | ||
|
|
There was a problem hiding this comment.
you can remove extra lines in this entire file
| if isinstance(r, dict): | ||
| out = [] | ||
| for k, v in r.items(): | ||
| if isinstance(v, dict) and 'file_id' in v: |
There was a problem hiding this comment.
a nitpick:
we can make these hardcoded strings as constants
| return hash(self.artifact) | ||
| except TypeError as e: | ||
| if isinstance(self.artifact, list): | ||
| return hash(str(self.artifact[:100])) |
There was a problem hiding this comment.
This is just to handle cases where something is not hashable.
| db: 'BaseDatabase' = None, # type: ignore[name-defined] | ||
| select: t.Optional[Select] = None, | ||
| distributed: bool = False, | ||
| ids: t.Optional[t.List[str]] = None, |
There was a problem hiding this comment.
This seems to cause problems with themypy.
superduperdb/core/serializable.py
Outdated
|
|
||
|
|
||
| def load_artifacts(d, getter, cache): | ||
| if isinstance(d, dict) or isinstance(d, list): |
There was a problem hiding this comment.
If isinstance(d, [dict, list])
superduperdb/core/serializable.py
Outdated
| serializer=v['serializer'], | ||
| ) | ||
| d[k] = cache[v['file_id']] | ||
| elif isinstance(v, dict) or isinstance(v, list): |
| @@ -36,6 +36,7 @@ | |||
| # to the rest of the code. | |||
| # It should be moved to the Server's initialization code where it can be available to | |||
| # all threads. | |||
| from ...core.artifact import Artifact, get_artifacts, infer_artifacts | |||
| from ...core.job import FunctionJob, ComponentJob, Job | |||
There was a problem hiding this comment.
I think we should be consistant with the imports style
nenb
approved these changes
Jul 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The vector-index notebooks were broken after the big refactoring which pivoted all
Componentsubclassesto
@dataclass. This PR provides the necessary changes.Related Issue(s)
This points towards the need to smoke-test at least some of the notebooks #389.