Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add unit tests for lancedb #459

Merged
merged 1 commit into from
Jul 19, 2023
Merged

Add unit tests for lancedb #459

merged 1 commit into from
Jul 19, 2023

Conversation

thejumpman2323
Copy link
Contributor

Description

Adds a unit test file for testing lancedb

Related Issue(s)

Checklist

  • Change or addition is covered by unit and/or integration tests. If bugfix, there should be at least one test that fails pre-PR and passes after.
  • Classes and functions substantially affected by this PR have sphinx format docstrings added or updated.
  • If your changes introduce modifications to functionality, behavior, or usage of the project, please ensure that the documentation is updated accordingly.

Additional Notes

@thejumpman2323 thejumpman2323 requested review from blythed and nenb July 18, 2023 20:47
nenb
nenb approved these changes Jul 19, 2023
View reviewed changes
Copy link
Contributor

@nenb nenb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Thank you for contributing this. These efforts are crucial to getting our test coverage in a very good place.

superduperdb/vector_search/lancedb_client.py Outdated Show resolved Hide resolved
tests/unittests/vector_search/test_lancedb.py Show resolved Hide resolved
tests/unittests/vector_search/test_lancedb.py Show resolved Hide resolved
tests/unittests/vector_search/test_lancedb.py Outdated Show resolved Hide resolved
tests/unittests/vector_search/test_lancedb.py Outdated Show resolved Hide resolved
@thejumpman2323 thejumpman2323 merged commit db0b095 into superduper-io:main Jul 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nenb nenb nenb approved these changes

@blythed blythed Awaiting requested review from blythed

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@thejumpman2323 @nenb @kartik4949