Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add more unit tests #464

Merged
merged 4 commits into from
Jul 20, 2023
Merged

Add more unit tests #464

merged 4 commits into from
Jul 20, 2023

Conversation

thejumpman2323
Copy link
Contributor

@thejumpman2323 thejumpman2323 commented Jul 19, 2023 •
edited
Loading

Description

Adds remaining unit tests for mongodb queries

resolves #465

Related Issue(s)

Checklist

  • Change or addition is covered by unit and/or integration tests. If bugfix, there should be at least one test that fails pre-PR and passes after.
  • Classes and functions substantially affected by this PR have sphinx format docstrings added or updated.
  • If your changes introduce modifications to functionality, behavior, or usage of the project, please ensure that the documentation is updated accordingly.

Additional Notes

@thejumpman2323 thejumpman2323 requested review from nenb and blythed July 19, 2023 10:30
@thejumpman2323 thejumpman2323 self-assigned this Jul 19, 2023
blythed
blythed reviewed Jul 19, 2023
View reviewed changes
Copy link
Collaborator

@blythed blythed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great. Looking good.

@thejumpman2323 thejumpman2323 changed the title Add unit tests for mongodb queries Add more unit tests Jul 19, 2023
@thejumpman2323 thejumpman2323 merged commit 7638037 into superduper-io:main Jul 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@blythed blythed blythed approved these changes

@nenb nenb Awaiting requested review from nenb

Assignees

@thejumpman2323 thejumpman2323

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Extend unit test cases
3 participants
@thejumpman2323 @blythed @kartik4949