Document and clean core/artifact.py #478
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -146,52 +51,67 @@ def __init__( | |||
| self.sha1 = sha1 | |||
|
|
|||
| def __hash__(self): | |||
| try: | |||
| if isinstance(self.artifact, list): | |||
| return hash(str(self.artifact[:100])) | |||
There was a problem hiding this comment.
Ah, that was already in there unfortunately. I thought I added a comment complaining, I WILL!
| from .artifact import Artifact | ||
|
|
||
|
|
||
| def put_artifacts_back(d, lookup, artifact_store: t.Optional[ArtifactStore] = None): |
There was a problem hiding this comment.
nitpick:
a return typehint :)
There was a problem hiding this comment.
All of these need typehints, I have a separate branch already in progress for this...
| @@ -36,8 +36,8 @@ | |||
| # to the rest of the code. | |||
| # It should be moved to the Server's initialization code where it can be available to | |||
| # all threads. | |||
| from ...core.artifact import ( | |||
* Sort config members * Fix some quotes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
See #408.
More to come, see https://github.com/rec/superduperdb-stealth/commits/artifact-tree