More cleaning #528
Merged
More cleaning #528
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blythed
reviewed
Jul 25, 2023
superduperdb/core/watcher.py
Outdated
| @@ -16,7 +16,7 @@ class Watcher(Component): | |||
| :param model: Model for processing data | |||
| :param key: Key to be bound to model | |||
| :param features: Dictionary of mappings from keys to models | |||
| :param active: Toggle to ``False`` to deactivate change data triggering | |||
| :param enabled: Toggle to ``False`` to deactivate change data triggering | |||
There was a problem hiding this comment.
I don't agree with this, since active=False does not mean this is out of action.
There was a problem hiding this comment.
So what does it mean then?
"active" sounds like "it is working" == "it is enabled"
There was a problem hiding this comment.
Active means that it's computing outputs every time they come in. If not active, then it still is used to watch for queries coming in, but not storing outputs in the DB.
blythed
requested changes
Jul 25, 2023
|
I'm not convinced either way, so I reverted that one change. :-) |
blythed
approved these changes
Jul 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
See #408.
This was just lying around in a branch. :-D