[ETHEREUM-CONTRACTS] emit Transfer event in updateMemberUnits() #2051
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changelog ReminderReminder to update the CHANGELOG.md for any of the modified packages in this PR.
|
|
the "fix" is working for etherscan: https://sepolia.basescan.org/token/0xbff63599fdf8b5225c98ee8767c1f177104ae8ec |
hellwolf
approved these changes
Jan 15, 2025
XKCD Comic RelifLink: https://xkcd.com/2051 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem: now that the pools have proper ERC20 metadata, we also want tooling like explorers to properly render the token state.
Since explorers heavily rely on the Transfer event as trigger for balance updates, it becomes a problem that
updateMemberUnitsdoesn't emit them. This PR changes that.updateMemberUnitsto a higher than previous amount is effectively a mint, thus a transfer from zero to the member.updateMemberUnitsto a lower than previous amount is effectively a burn, thus a transfer from the member to zero.Already deployed to base-sepolia for test purposes.