[AUDIT/FIX] Issue #119 - Frontrunning instant unlocks #25
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to Sherlock Issue
Note : this PR also addresses concerns of Issue 47
Implementation Details :
This PR introduce a major design refactoring in regards with the tax sharing mechanism.
Fontaine.solis no longer responsible for distributing the taxes.StakingRewardController.sol: this contract is now responsible for accumulating the taxes and distribute it in a distribution flow manner. That stream is meant to perpetually be recalculated on a 6 months sliding window.Note : The
Fontaine.solstorage layout had been modified but should not be an issue as in the currently live system, no Fontaine had ever been deployed.