keep gossip address the same as the actor address

[runsisi]

No description provided.

[jeromegn]

Is that causing issues?

[runsisi]

we store actor address (self.external_addr().unwrap_or_else(|| self.gossip_addr()))¹ in __corro_members table², while in spawn_swim_announcer to skip local node announce³ gossip address (gossip_server_endpoint.local_addr())⁴ is used as local address, i.e., our_addr. i think this is not correct.

maybe we should change generate_bootstrap ⁵ signiture to ignore skip both gossip address and external address?

Footnotes

1. https://github.com/superfly/corrosion/blob/e35acab3f3d6bb5499104ddf3b3dda7245a2437a/crates/corro-types/src/agent.rs#L141 ↩

2. https://github.com/superfly/corrosion/blob/e35acab3f3d6bb5499104ddf3b3dda7245a2437a/crates/corro-agent/src/broadcast/mod.rs#L709 ↩

3. https://github.com/superfly/corrosion/blob/e35acab3f3d6bb5499104ddf3b3dda7245a2437a/crates/corro-agent/src/agent/bootstrap.rs#L39 ↩

4. https://github.com/superfly/corrosion/blob/e35acab3f3d6bb5499104ddf3b3dda7245a2437a/crates/corro-agent/src/agent/run_root.rs#L56 ↩

5. https://github.com/superfly/corrosion/blob/e35acab3f3d6bb5499104ddf3b3dda7245a2437a/crates/corro-agent/src/agent/bootstrap.rs#L16 ↩

[somtochiama]

maybe we should change generate_bootstrap 5 signiture to ignore skip both gossip address and external address?

@runsisi I think this is a better solution.