Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Outdated dockerfile description in "Run a Go App" doc #1869

Open
uniphil opened this issue Nov 8, 2024 · 0 comments · May be fixed by #1870
Open

Outdated dockerfile description in "Run a Go App" doc #1869

uniphil opened this issue Nov 8, 2024 · 0 comments · May be fixed by #1870

Comments

@uniphil
Copy link

uniphil commented Nov 8, 2024

Title: Run a Go App
Location: https://fly.io/docs/languages-and-frameworks/golang/
Source: https://github.com/superfly/docs/blob/main/languages-and-frameworks/golang.html.markerb

Describe the issue

Section: Inside Dockerfile

superfly/flyctl#3312 changed the default golang Dockerfile to use a CGO-enabled Debian base instead of Alpine. The docs currently have it reversed.
uniphil added a commit to uniphil/fly-io-docs that referenced this issue Nov 8, 2024
@uniphil
Update the golang Dockerfile base image name to match the current tem…
8db0a1f 
…plate

fixes superfly#1869

The golang dockerfile template was updated in superfly/flyctl#3312 to use Debian instead of Alpine -- this change brings the relevant docs up to date.
@uniphil uniphil linked a pull request Nov 8, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update golang Dockerfile docs to match template changes uniphil/fly-io-docs
1 participant
@uniphil