Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reference docs for [deploy.release_command_vm] #1875

Merged
merged 3 commits into from
Nov 27, 2024
Merged

Conversation

dangra
Copy link
Member

@dangra dangra commented Nov 26, 2024

Summary of changes

Preview

Related Fly.io community and GitHub links

Notes

Copy link
Contributor

@Roadmaster Roadmaster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM two minor suggestions, with appropriate doses of salt as they come from me, a non-native speaker :)

@@ -184,6 +184,16 @@ The `release_command` value replaces `CMD` in the temporary Machine. This is use
The temporary Machine has full access to the network, environment variables and secrets, but *not* to persistent volumes. Changes made to the file system on the temporary Machine will not be retained or deployed. The building/compiling of your project should be done in your Dockerfile. If you need to modify persistent volumes or configure your application, consider making use of `CMD` or `ENTRYPOINT` in your Dockerfile, or of a [process group command](#the-processes-section).

The temporary Machine inherits the size from the largest Machine in the default process group of the app as of flyctl v0.0.508 (they also default larger on empty/new apps, using the Machine `shared-cpu-2x` preset). The default process group is defined as either the `app` process, or the first process group in alphabetical order (if an `app` process is not present).
It is possible to explicitly set the Machine size by setting `[deploy.release_command_vm]` like in:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"It is also possible to explicitly define the Machine size..." mainly to better chain from the previous sentences and avoid a bit of repetition?

@@ -184,6 +184,16 @@ The `release_command` value replaces `CMD` in the temporary Machine. This is use
The temporary Machine has full access to the network, environment variables and secrets, but *not* to persistent volumes. Changes made to the file system on the temporary Machine will not be retained or deployed. The building/compiling of your project should be done in your Dockerfile. If you need to modify persistent volumes or configure your application, consider making use of `CMD` or `ENTRYPOINT` in your Dockerfile, or of a [process group command](#the-processes-section).

The temporary Machine inherits the size from the largest Machine in the default process group of the app as of flyctl v0.0.508 (they also default larger on empty/new apps, using the Machine `shared-cpu-2x` preset). The default process group is defined as either the `app` process, or the first process group in alphabetical order (if an `app` process is not present).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe rephrase to "By default, the temporary Machine inherits..." yadda yadda

minor phrasing updates
@Roadmaster Roadmaster merged commit 6f6caa6 into main Nov 27, 2024
1 of 2 checks passed
@Roadmaster Roadmaster deleted the release-command-vm branch November 27, 2024 21:20
@dangra
Copy link
Member Author

dangra commented Nov 28, 2024

👏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants