Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change launch http service checks to be service checks (was top level) #4118

Merged
merged 2 commits into from
Dec 12, 2024
Merged

Change launch http service checks to be service checks (was top level) #4118

merged 2 commits into from
Dec 12, 2024

Conversation

rubys
Copy link
Contributor

@rubys rubys commented Dec 12, 2024

This will (eventually) enable auto start to wait until the service is ready before the proxy starts routing requests to the machine.

dangra
dangra approved these changes Dec 12, 2024
View reviewed changes
Copy link
Member

@dangra dangra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pre-approving. It may need some test case updates.

@rubys rubys merged commit 836b759 into master Dec 12, 2024
30 checks passed
@rubys rubys deleted the launch-http-service-check branch December 12, 2024 21:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dangra dangra dangra approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rubys @dangra