Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add an option to skip sectors on subcode desync #163

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Add an option to skip sectors on subcode desync #163

wants to merge 1 commit into from

Conversation

Sazpaimon
Copy link
Contributor

@Sazpaimon Sazpaimon commented Jun 6, 2024 •
edited
Loading

Solves #161

@Sazpaimon Sazpaimon force-pushed the feature/skip-subcode-desync branch from 5c5c9e2 to 89962dc Compare June 6, 2024 04:45
superg
superg reviewed Jun 29, 2024
View reviewed changes
Copy link
Owner

@superg superg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This requires more in depth review, I'll work on this once I get back to active development, hopefully in a week-two.
Thank you for the patience!

@superg
Copy link
Owner

superg commented Aug 19, 2024 •
edited
Loading

I went over it one more time, the option makes sense. I'd add it only to the new dump code because it will soon be ready.
Let me finish some features in new dump code and I will have that in.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@superg superg superg left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Sazpaimon @superg