Abandon magic check with degenerate range #187
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This became easier to hit when the VideoNow checks were added. |
|
Makes sense, I'll approve but please fix formatting. |
Protects against crashing if track 1 is all zero
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When track 1 is entirely zero,
byte_offset_by_magic()can be called withlba_end(the end of track 1) less thanlba_start(the first non-zero byte). This leaves an overflowed value insectors_to_check, likely leading to OOM or another overflow in the allocation ofdata. This patch abandons the check early if the range is degenerate.