Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR generates the DMI/PFI/SS files that redump.org and abgx360 care about. The functionality is gated behind a
--generate-extra-xbox
option, so these derivative files are not generated by default.{image_name}.dmi
is made by trimming the 4-byte scsi header from{image_name}.manufacturer
{image_name}.pfi
is made by trimming the 4-byte scsi header from{image_name}.physical
{image_name}.ss
is made by cleaning the{image_name}.security
file with the same method that ss_sector_range usesAdditionally, the sector ranges are logged when this occurs.
I initially wanted to put this functionality inside
redumper split
howeversplit
only runs for CD dumps, and trying to hack it to run for Xbox dumps results in messy code.I also wanted to put the DMI/PFI/SS hashes and sector range printing into
redumper info
however theinfo
step only reads from the main dump (ISO), and hacking it to read from the auxiliary files again results in messy code.So, the way I've done it is the cleanest way I could come up with.