Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate extra xbox files #198

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Generate extra xbox files #198

wants to merge 4 commits into from

Conversation

Deterous
Copy link
Contributor

This PR generates the DMI/PFI/SS files that redump.org and abgx360 care about. The functionality is gated behind a --generate-extra-xbox option, so these derivative files are not generated by default.

  • {image_name}.dmi is made by trimming the 4-byte scsi header from {image_name}.manufacturer
  • {image_name}.pfi is made by trimming the 4-byte scsi header from {image_name}.physical
  • {image_name}.ss is made by cleaning the {image_name}.security file with the same method that ss_sector_range uses
    Additionally, the sector ranges are logged when this occurs.

I initially wanted to put this functionality inside redumper split however split only runs for CD dumps, and trying to hack it to run for Xbox dumps results in messy code.
I also wanted to put the DMI/PFI/SS hashes and sector range printing into redumper info however the info step only reads from the main dump (ISO), and hacking it to read from the auxiliary files again results in messy code.
So, the way I've done it is the cleanest way I could come up with.

@Deterous
Copy link
Contributor Author

Alternatively, if you think these files aren't within scope of Redumper, this can be removed/altered.
Instead outputting these derivative files can be within scope of MPF and the like (ss_sector_range)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant