Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SW-1244] Move accounts vuex state to composable #2334

Merged
merged 4 commits into from
Oct 4, 2023
Merged

[SW-1244] Move accounts vuex state to composable #2334

merged 4 commits into from
Oct 4, 2023

Conversation

peronczyk
Copy link
Collaborator

No description provided.

@peronczyk peronczyk force-pushed the refactor/move-account-vuex-state-to-composable branch 10 times, most recently from 7b464ed to 1b5503b Compare September 15, 2023 13:29
@peronczyk peronczyk marked this pull request as ready for review September 15, 2023 13:35
@peronczyk peronczyk changed the title [DRAFT] Move accounts vuex state to composable [SW-1244] Move accounts vuex state to composable Sep 15, 2023
pstachel
pstachel reviewed Sep 18, 2023
View reviewed changes
src/composables/accounts.ts Outdated Show resolved Hide resolved
src/protocols/aeternity/helpers/index.ts Outdated Show resolved Hide resolved
src/protocols/aeternity/libs/AeSdkSuperhero.ts Show resolved Hide resolved
src/protocols/bitcoin/libs/BitcoinAdapter.ts Outdated Show resolved Hide resolved
src/composables/accounts.ts Outdated Show resolved Hide resolved
@peronczyk peronczyk force-pushed the refactor/move-account-vuex-state-to-composable branch 2 times, most recently from 514fef1 to 94c7d99 Compare September 18, 2023 09:13
@github-actions
Copy link

Deployed to refactor-move-account-vuex-state-to-composable.wallet.z52da5wt.xyz, artifacts

@peronczyk peronczyk force-pushed the refactor/move-account-vuex-state-to-composable branch from 94c7d99 to 0c703d9 Compare September 18, 2023 09:44
@peronczyk peronczyk force-pushed the refactor/move-account-vuex-state-to-composable branch 10 times, most recently from 1b4ec73 to 4517307 Compare September 24, 2023 22:04
@peronczyk peronczyk force-pushed the refactor/move-account-vuex-state-to-composable branch from 4517307 to 0a0202f Compare September 26, 2023 10:53
pstachel
pstachel approved these changes Sep 26, 2023
View reviewed changes
src/composables/accounts.ts Outdated Show resolved Hide resolved
src/composables/accounts.ts Outdated Show resolved Hide resolved
src/popup/components/Modals/AccountCreate.vue Show resolved Hide resolved
subhod-i
subhod-i suggested changes Sep 27, 2023
View reviewed changes
src/utils/common.ts Show resolved Hide resolved
src/store/plugins/fungibleTokens.js Show resolved Hide resolved
src/store/modules/accounts/index.js Show resolved Hide resolved
src/protocols/aeternity/libs/AeSdkSuperhero.ts Show resolved Hide resolved
@peronczyk peronczyk force-pushed the refactor/move-account-vuex-state-to-composable branch from 0a0202f to d927c81 Compare September 27, 2023 08:45
subhod-i
subhod-i suggested changes Sep 27, 2023
View reviewed changes
src/composables/transactionTx.ts Outdated Show resolved Hide resolved
src/composables/composablesHelpers.ts Outdated Show resolved Hide resolved
@subhod-i subhod-i requested a review from davidyuk September 27, 2023 10:58
subhod-i
subhod-i approved these changes Sep 27, 2023
View reviewed changes
Copy link
Contributor

@subhod-i subhod-i left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code changes LGTM, We need to test this if the changes in the PR can read the existing storage keys and their data. @Liubov-crypto Please use the develop branch and make sure to have an account with few interactions and then use this PR to check the existing state is continued/resumed.

@peronczyk peronczyk force-pushed the refactor/move-account-vuex-state-to-composable branch from 66985da to 51c7e86 Compare September 27, 2023 12:23
CedrikNikita
CedrikNikita approved these changes Sep 27, 2023
View reviewed changes
Copy link
Collaborator

@CedrikNikita CedrikNikita left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code changes look reasonable.

@peronczyk peronczyk mentioned this pull request Sep 28, 2023
Merged
@peronczyk peronczyk force-pushed the refactor/move-account-vuex-state-to-composable branch from fc1088e to e255040 Compare October 4, 2023 07:16
@peronczyk peronczyk merged commit 10a5004 into develop Oct 4, 2023
4 checks passed
@peronczyk peronczyk deleted the refactor/move-account-vuex-state-to-composable branch October 4, 2023 11:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pstachel pstachel pstachel approved these changes

@konradodo konradodo konradodo approved these changes

@subhod-i subhod-i subhod-i approved these changes

@CedrikNikita CedrikNikita CedrikNikita approved these changes

@davidyuk davidyuk Awaiting requested review from davidyuk

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@peronczyk @CedrikNikita @subhod-i @konradodo @pstachel