Skip to content

Commit

Permalink
setting z_step reset correctly current slices #784
Browse files Browse the repository at this point in the history
  • Loading branch information
remi durand committed Jun 4, 2021
1 parent 98cfe57 commit 3b1b2b6
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 4 deletions.
3 changes: 2 additions & 1 deletion src/libslic3r/Print.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -230,7 +230,8 @@ bool Print::invalidate_state_by_config_options(const std::vector<t_config_option
// Spiral Vase forces different kind of slicing than the normal model:
// In Spiral Vase mode, holes are closed and only the largest area contour is kept at each layer.
// Therefore toggling the Spiral Vase on / off requires complete reslicing.
|| opt_key == "spiral_vase") {
|| opt_key == "spiral_vase"
|| opt_key == "z_step") {
osteps.emplace_back(posSlice);
} else if (
opt_key == "filament_type"
Expand Down
6 changes: 3 additions & 3 deletions src/libslic3r/PrintObject.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -715,8 +715,7 @@ namespace Slic3r {
|| opt_key == "hole_size_compensation"
|| opt_key == "hole_size_threshold"
|| opt_key == "hole_to_polyhole"
|| opt_key == "hole_to_polyhole_threshold"
|| opt_key == "z_step") {
|| opt_key == "hole_to_polyhole_threshold") {
steps.emplace_back(posSlice);
} else if (opt_key == "support_material") {
steps.emplace_back(posSupportMaterial);
Expand Down Expand Up @@ -750,7 +749,8 @@ namespace Slic3r {
steps.emplace_back(posSupportMaterial);
} else if (opt_key == "bottom_solid_layers") {
steps.emplace_back(posPrepareInfill);
if (m_print->config().spiral_vase) {
if (m_print->config().spiral_vase
|| opt_key == "z_step") {
// Changing the number of bottom layers when a spiral vase is enabled requires re-slicing the object again.
// Otherwise, holes in the bottom layers could be filled, as is reported in GH #5528.
steps.emplace_back(posSlice);
Expand Down

0 comments on commit 3b1b2b6

Please sign in to comment.