Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crazy Internal Brim perimeters when supports overlay it (different behaviour to same with external Brim) #1526

Open
gpread opened this issue Sep 2, 2021 · 5 comments

Comments

@gpread
Copy link

gpread commented Sep 2, 2021

2.3.56.8

Creality CR-10, Marlin 2.0.8.2
Windows 10 - 20H2 (19402.1165)

Unlike when supports overlap/overlay an external brim (where it routes the brim perimeters around the support structures) with an internal brim, its creating the brim perimeters as is they were cut by the support structures.

image

This means they are pretty much unprintable as segments of the brim perimeters are tiny in length. It also surely means the adhesion of the object is lower since the adhesion of the brim has been lowered.

To me, it seems like for both internal and external brims it would be technically easier just to consider once the brim has been calculated that its part of the print object and have the supports then sit on top. Currently it makes the brim's more complex and difficult to print, which defeats their objective somewhat (to improve adhesion of the 1st layer).

@gpread
Copy link
Author

gpread commented Sep 2, 2021

Project file for the screenshot & Issue

InsideBrim_with_Supports_SSlicr_Issue#1526.zip

@supermerill supermerill added bug Something isn't working as intended fixed for the next version That means that you should be able to test it in the latest nightly build labels Sep 4, 2021
supermerill added a commit that referenced this issue Sep 4, 2021
supermerill added a commit that referenced this issue Sep 6, 2021
supermerill added a commit that referenced this issue Sep 6, 2021
@supermerill supermerill added fix is live in the last release Please download /build the last release and try to reproduce. and removed fixed for the next version That means that you should be able to test it in the latest nightly build labels Sep 6, 2021
@gpread
Copy link
Author

gpread commented Sep 7, 2021

2.3.57.0, Creality CR-10V3 (modified), Marlin 2.0.8.2 & Windows 10 - 20H2 (19402.1165)

Just tried this and its clearly a big improvement for the Internal Brim case, Thanks!

However, Brim and supports interaction (may apply to raft also, I didn't check) to me is still somewhat clumsy, wasteful, hard to print and its also inconsistent depending on whether the brim is internal or external.

It would not be such an issue if there was not also often unnecessary support structure placed on the 1st layer. When there is a feature needing support but which adjacent to but only on one side of the perimeter/external wall of the object , there is a small support line created on the opposite side of the wall. This cannot be prevented by using modifiers nor enforcers from my experience.

image

image

@gpread
Copy link
Author

gpread commented Sep 7, 2021

So with internal brim it now looks like

image

Which alone is usable/workable. However, if external brim is used (alone or in addition) then it get corrupted and the interaction of support and brim(s) are ugly (it tries to tightly hug the support and causes the perimeters to have tiny but frequent perturbations)

image
Both Internal and External

image
Just External

My preference/suggestion would be the cleanest solution would be to have supports processed only after brim and/or raft is applied (so they sit on top and the brims are only clean/simple perimeters). I believe this would also be the most robust/effective in terms of the purposes of brim and supports and also allow the highest practical speeds for the first layer.

If not that then its desirable to at least get the external brim behaviour to mirror the new/current internal brim behaviour for interaction with supports.

@supermerill
Copy link
Owner

My preference/suggestion would be the cleanest solution would be to have supports processed only after brim and/or raft is applied (so they sit on top and the brims are only clean/simple perimeters). I believe this would also be the most robust/effective in terms of the purposes of brim and supports and also allow the highest practical speeds for the first layer.

I'll see that after the merge with prusa 2.4, as they changed the support generation.

@supermerill supermerill added enhancement and removed bug Something isn't working as intended fix is live in the last release Please download /build the last release and try to reproduce. labels Sep 8, 2021
@supermerill supermerill added this to the after 2.4 merge milestone Sep 8, 2021
@gpread
Copy link
Author

gpread commented Sep 8, 2021 via email

@supermerill supermerill removed this from the after 2.4 merge milestone Nov 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants