Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

hole_size_threshold = 0 #1540

Closed
5axes opened this issue Sep 9, 2021 · 1 comment
Closed

hole_size_threshold = 0 #1540

5axes opened this issue Sep 9, 2021 · 1 comment
Labels
bug Something isn't working as intended fix is live in the last release Please download /build the last release and try to reproduce.

Comments

@5axes
Copy link

5axes commented Sep 9, 2021 •
edited
Loading

According to the tooltips if we set to 0 to let the hole_size_compensation apply fully for all detected holes (Convexe holes).

But If i fix this value to 0 then no compensation is added to the hole.

Tested on release 2.3.56.8

hole_size_threshold fixed to 0 => No compensation

image

Extrem copensation with a hole_size_threshold fixed to 9999. In this case every convex hole are modified.

image

Sample test part :
Monotonic.zip
@5axes 5axes changed the title hole_size_threshold hole_size_threshold = 0 Sep 9, 2021
@supermerill supermerill added the bug Something isn't working as intended label Sep 9, 2021
@tome9111991
Copy link

confirm on 2.3.57.0

@supermerill supermerill added the fixed for the next version That means that you should be able to test it in the latest nightly build label Sep 26, 2021
supermerill added a commit that referenced this issue Sep 26, 2021
@supermerill
fix hole_size_threshold when 0
22b2d46 
#1540
@supermerill supermerill added fix is live in the last release Please download /build the last release and try to reproduce. and removed fixed for the next version That means that you should be able to test it in the latest nightly build labels Oct 8, 2021
@supermerill supermerill mentioned this issue Oct 27, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working as intended fix is live in the last release Please download /build the last release and try to reproduce.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@supermerill @5axes @tome9111991