Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Ensure Vertical Shell Thickness" conflicts with Spiral Vase instructions #1582

Closed
yonkiman opened this issue Sep 22, 2021 · 1 comment
Closed
Labels
bug Something isn't working as intended fix is live in the last release Please download /build the last release and try to reproduce.

Comments

@yonkiman
Copy link

Describe the bug
When you select Spiral vase mode, a pop-up appears that says "Ensure vertical shell thickness enabled". However it does not automatically check the Ensure vertical shell thickness box. When you manually select Ensure vertical shell thickness, the pop-up reappears, and the Ensure vertical shell thickness enabled becomes unchecked when you close the pop-up.

In other words, while the pop-up says "Ensure vertical shell thickness enabled", it behaves as if it's saying "Ensure vertical shell thickness disabled"

To Reproduce
Steps to reproduce the behavior:

  1. Select Spiral vase mode.
  2. Note that pop-up says "Ensure vertical shell thickness enabled"
  3. Attempt to enable Ensure vertical shell thickness
  4. See what happens

>> Project File <<
spiral vase issue.zip

Expected behavior
Would expect pop-up and behavior to match

Screenshots
Screenshot 2021-09-22 06 10 16

Desktop (please complete the following information):

  • OS: Windows 10
  • Version: 2.3.57.0
@supermerill
Copy link
Owner

oh, it's a bad merge

there is a change by prusa that change from disabled to enabled
the "ensure vertical shell wall" is enforced in spiral vase mode to extend the bottom of the vase to the vase hull.

@supermerill supermerill added bug Something isn't working as intended fixed for the next version That means that you should be able to test it in the latest nightly build labels Sep 26, 2021
supermerill added a commit that referenced this issue Sep 27, 2021
The "ensure vertical shell wall" is enforced in spiral vase mode to extend the bottom of the vase to the vase hull.
#1582
@supermerill supermerill added fix is live in the last release Please download /build the last release and try to reproduce. and removed fixed for the next version That means that you should be able to test it in the latest nightly build labels Oct 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working as intended fix is live in the last release Please download /build the last release and try to reproduce.
Projects
None yet
Development

No branches or pull requests

2 participants