Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Thumbnails not added to Gcode #222

Closed
Jack77777777 opened this issue May 3, 2020 · 15 comments
Closed

Thumbnails not added to Gcode #222

Jack77777777 opened this issue May 3, 2020 · 15 comments
Labels
fix is live in the last release Please download /build the last release and try to reproduce. problem

Comments

@Jack77777777
Copy link

Version

Version: 2.2.49
Build: slic3r++_2.2.49_2020-04-21

Operating system type + version

Windows 10 Pro, Version 1909

3D printer brand / version + firmware version (if known)

Anycubic i3 Mega s, Marlin 1.1.9 Custom Firmware

Behavior

  • Describe the problem
    No thumbnails added to Gcode. It´s added to Gcode using Prusaslicer
  • Steps needed to reproduce the problem
    Go to Help->Show configuration folder->printer and add thumbnails = 16x16,220x124 to .ini
  • Expected Results
    Generating Gcode with thumbnail section in it
  • Actual Results
    No thumbnails generated
    Adding Gcode of S++ and Prusaslicer how it should look like.

Is this a new feature request?
Perhaps

Project File (.3MF) where problem occurs

All_Files.zip

@supermerill supermerill added the bug Something isn't working as intended label May 3, 2020
supermerill added a commit that referenced this issue May 3, 2020
@supermerill supermerill added the fixed for the next version That means that you should be able to test it in the latest nightly build label May 3, 2020
@vertigo235
Copy link

Ahh good to know, I thought I was just doing something wrong

@supermerill supermerill added fix is live in the last release Please download /build the last release and try to reproduce. and removed fixed for the next version That means that you should be able to test it in the latest nightly build labels May 10, 2020
@Jack77777777
Copy link
Author

Great, it´s working !

@jneilliii
Copy link

Was this added as a setting that could be controlled via the UI or only in the ini file directly? I ask because there is a request on the official PrusaSlicer repo for this and it seems you guys are more open to change/making that happen.

@3d-gussner
Copy link

See prusa3d#4127

@supermerill supermerill reopened this May 15, 2020
@supermerill supermerill added also in prusaslicer problem and removed bug Something isn't working as intended fix is live in the last release Please download /build the last release and try to reproduce. labels May 15, 2020
@supermerill
Copy link
Owner

The setting was hidden. I added it into the general tab of the printer.
prusa mini is 16x16,220x124
sl1 is 400x400,800x480
if you set it to 0x0 0x0, you won't export a thumbnail in the gcode. If it's set, you will.

@jneilliii @3d-gussner does this resolve the issue?

@supermerill supermerill added the fixed for the next version That means that you should be able to test it in the latest nightly build label Aug 17, 2020
@jneilliii
Copy link

That works for me assuming it's available for all printers and not just the mini and sl1. Looking forward to that release.

supermerill pushed a commit that referenced this issue Aug 17, 2020
@supermerill supermerill added fix is live in the last release Please download /build the last release and try to reproduce. and removed fixed for the next version That means that you should be able to test it in the latest nightly build labels Aug 24, 2020
@fernandex00
Copy link

i got crash when trying to put a value, windows 10 superslicer 2.2.53

@jneilliii
Copy link

I had a similar issue @fernandex00 but got past it by creating a new printer profile.

@fernandex00
Copy link

thank you, i will try that

@neophyl
Copy link

neophyl commented Aug 26, 2020

I saw that too, it seems it is initially set to 0 x 0.00, when I tried to edit it caused superslicer to shut down. I reopened though and for some reason they were now set at 0 x 0 so didnt cause a problem and I didnt have to resave the profile.

@supermerill supermerill removed also in prusaslicer fix is live in the last release Please download /build the last release and try to reproduce. labels Aug 26, 2020
@supermerill
Copy link
Owner

supermerill commented Aug 26, 2020

@fernandex00 @jneilliii @neophyl
Can you send me a .3mf created just before you modify the setting that makes it crash ?

@neophyl
Copy link

neophyl commented Aug 26, 2020

I can reproduce it but not with a 3mf file.

The sequence I used is as follows-

Install clean , no existing profiles etc.
Can run wizard to install printers etc or skip, doesn't matter but make sure you have expert mode on so you can see the printer settings.
Import Config bundle
PrusaSlicer_config_bundle_work_20190627.zip - theres a hodge podge of 101 presets in there that I need to clean up lol.
That will usually then select one of the imported profiles.
Change to the Printer>general page. At this point the thumbnail settings look like this -
image
Notice the -0.00 for Y on both.
Edit the small Y settings to make 0. Then try and edit the large Y settings. For me it then hangs and after a few seconds shuts down.
Once you reopen the software though and go back to that screen the settings are both 0 already and there doesnt seem to be any other issue. With that printer profile or any of the others. If I save the 3mf file with the settings as -0.00 and then restart and load the 3mf the values are 0.

I suspect its an initialisation issue.

@supermerill
Copy link
Owner

supermerill commented Aug 26, 2020

Can't reproduce with your steps, using the local settings to have a clean "install" and a fresh downloaded zip release file.
i have 0 ,0, not 0 -0.00
I'm a bit confused,
I'll try to put some safeguards on these fields to have them only positive or null, should be enough

@randellhodges
Copy link

I also had the crash with 2.2.53 on windows. I opened up my machine's .ini file and noticed:
thumbnails =
I changed it to:
thumbnails = 16x16,220x220

Then when I re-opened superslicer I was able to change it to 16x16 and 220x124 without it crashing. I verified it wrote
thumbnails = 16x16,220x124
to the machine's .ini file as expected.

@supermerill
Copy link
Owner

thumbnails =

ok, i can replicate that.
I've added another safeguard to correct this problem.

@supermerill supermerill added fixed for the next version That means that you should be able to test it in the latest nightly build and removed could not reproduce labels Sep 6, 2020
@supermerill supermerill added fix is live in the last release Please download /build the last release and try to reproduce. and removed fixed for the next version That means that you should be able to test it in the latest nightly build labels Oct 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix is live in the last release Please download /build the last release and try to reproduce. problem
Projects
None yet
Development

No branches or pull requests

8 participants