Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New version check seems to have issue with last position #2301

Closed
RealDeuce opened this issue Feb 1, 2022 · 4 comments
Closed

New version check seems to have issue with last position #2301

RealDeuce opened this issue Feb 1, 2022 · 4 comments
Labels
bug Something isn't working as intended fix is live in the last release Please download /build the last release and try to reproduce.

Comments

@RealDeuce
Copy link

What happened?

Built and ran 2.3.57.10 when 2.3.57.9 is the latest release... SuSl says there's a new version available.

Project file & How to reproduce

Build current Nigthly, run.

Version

2.3.57.10 Nigthly

Operating system

FreeBSD 12.3-RELEASE

Printer model

Voron 2.4 with Stealthburner

@RealDeuce
Copy link
Author

image

@RealDeuce
Copy link
Author

> grep -r version_online .
./SuperSlicer.ini:version_online = 2.3.57.9

@RealDeuce
Copy link
Author

Oh, this is on purpose maybe?

                //if (*Semver::parse(SLIC3R_VERSION_FULL) < *Semver::parse(into_u8(evt.GetString()))) {
                    this->plater_->get_notification_manager()->push_notification(NotificationType::NewAppAvailable);
                //}

@supermerill
Copy link
Owner

supermerill commented Feb 2, 2022

problem is "10" < "9"
and I had no time to tinker with it to parse the string correctly into a valid version number.
note: The real test is at PresetUpdater:l291

But I think it may be needed if I don't want many issues about that flourishing.

@supermerill supermerill added problem bug Something isn't working as intended fixed for the next version That means that you should be able to test it in the latest nightly build and removed problem labels Feb 2, 2022
supermerill added a commit that referenced this issue Feb 3, 2022
Allow 2.3.10 to be > than 2.3.9
allow 1.1.1.1 and not only 1.1.1
#2301
@supermerill supermerill added fix is live in the last release Please download /build the last release and try to reproduce. and removed fixed for the next version That means that you should be able to test it in the latest nightly build labels Feb 13, 2022
DzzD pushed a commit to DzzD/SuperSlicer that referenced this issue Apr 17, 2022
Allow 2.3.10 to be > than 2.3.9
allow 1.1.1.1 and not only 1.1.1
supermerill#2301
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working as intended fix is live in the last release Please download /build the last release and try to reproduce.
Projects
None yet
Development

No branches or pull requests

2 participants