Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

s_wall_thickness is not setting values as per description #4082

Closed
Tau512 opened this issue Jan 18, 2024 · 3 comments
Closed

s_wall_thickness is not setting values as per description #4082

Tau512 opened this issue Jan 18, 2024 · 3 comments
Labels
bug Something isn't working as intended fix is live in the last release Please download /build the last release and try to reproduce.

Comments

@Tau512
Copy link

Tau512 commented Jan 18, 2024

What happened?

I'm not sure if this is a problem with some overextrusion i'm seeing recently (not sure if slicer or print - still trying to figure it out!!) but i've noticed the following along with various nightly fixes with flow/extrusion related issues:

image

in the case of a 0.4mm nozzle (as defined with nozzle_diameter[0]) and as per the description of wall thickness, it states it must be between nozzle size and 2*nozzle size; so 0.4-0.8mm.

Trying some random values, it appears it also allows it substantially over 2x nozzle, but also seems to be doing something wrong with calculations as 1.299999 results in a 0.91 for 1 wall, or 1.78mm for 2 walls :
image

Project file & How to reproduce

set 0.4mm nozzle.

adjust wall thickness values inside description limits.
adjust wall thickness values outside of description limits

Version

GTK3 ubu64 nightly 14441cf AppImage

Operating system

No response

Printer model

No response

@legend069
Copy link

this is likely a floating point calculation error
can reproduce on 2.4.58.5 - windows
typing "1.3" into s_wall_thickness pressing enter and it auto corrects itself to 1.2999999x

@Tau512
Copy link
Author

Tau512 commented Jan 19, 2024

it wasnt so much the rounding error, but the fact the description shows it can only be UPTO 2x nozzle (so 0.8 max wall thickness).

same 0.4mm nozzle with 1.1mm thickness = 1.14mm for 1 perimeter which isnt that far off 3x nozzle size:
image

@supermerill supermerill added the bug Something isn't working as intended label Jan 23, 2024
@supermerill
Copy link
Owner

There was an error.
The external perimeter half-spacing was used as a full spacing (so it was a bit bigger than expected).
fixed for next version.

@supermerill supermerill added the fixed for the next version That means that you should be able to test it in the latest nightly build label Jan 23, 2024
supermerill added a commit that referenced this issue Jan 23, 2024
Also better rounding for scripted float.
#4082
supermerill added a commit that referenced this issue Jan 24, 2024
Also better rounding for scripted float.
#4082
@supermerill supermerill added fix is live in the last release Please download /build the last release and try to reproduce. and removed fixed for the next version That means that you should be able to test it in the latest nightly build labels Feb 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working as intended fix is live in the last release Please download /build the last release and try to reproduce.
Projects
None yet
Development

No branches or pull requests

3 participants