Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Gap Fill on thin empty surfaces #982

Closed
raidolo opened this issue Feb 26, 2021 · 3 comments
Closed

Add Gap Fill on thin empty surfaces #982

raidolo opened this issue Feb 26, 2021 · 3 comments
Labels
fix is live in the last release Please download /build the last release and try to reproduce. new Feature New feature or request

Comments

@raidolo
Copy link

raidolo commented Feb 26, 2021

Version

2.3.55.5

Operating system type + version

Windows 10 1809

3D printer brand / version + firmware version (if known)

Not relevant

Behavior

Gap Fill is not done if the Solid Infill Area Threshold is lower than the default value (70)
If I set the Solid Infill Area Threshold to 1, the layer has the standard infill, but there's no gap fill where it "should" be.
Instead SS tries to use the infill also in the gap, and depending on what infill is in use, the part looks more or less filled.

  • Expected Results
    Immagine 2021-02-26 163536

  • Actual Results

Immagine 2021-02-26 163507

Project File (.3MF) where problem occurs

It's a benchy :) but still...here it is....

3DBenchy.zip

@supermerill
Copy link
Owner

supermerill commented Mar 18, 2021

In the first pic, it's the gap fill from the solid infill (because you have rectilinear with gapfill, if you use only rectilinear, you won't have a gapfill either).
If you only want 2 perimeters, no need to add more gapfill in-between because the expected wall width is already achieved.

If you don't want a solid layer (that's why you reduced the 'Solid Infill Area Threshold', right?), I don't see what is wrong on the second pic: it has 2 perimeters and a sparse infill

@supermerill supermerill added the working as intended unless you prove me wrong. label Mar 18, 2021
@raidolo
Copy link
Author

raidolo commented Mar 19, 2021

I want two perimeters but not completely empty walls, if there's not enough space to create a sparse infill, then I think it's best to do a gap fill, like Prusa Slicer does. It just does gap fill there and the sparse infill on the front area.

@supermerill
Copy link
Owner

that's a new feature, with a new gap-fill threshold.

@supermerill supermerill added new Feature New feature or request and removed working as intended unless you prove me wrong. labels Mar 19, 2021
@supermerill supermerill changed the title Gap Fill not consistent Add Gap Fill on thin empty surfaces Mar 19, 2021
@supermerill supermerill added the fixed for the next version That means that you should be able to test it in the latest nightly build label Aug 21, 2021
@supermerill supermerill added fix is live in the last release Please download /build the last release and try to reproduce. and removed fixed for the next version That means that you should be able to test it in the latest nightly build labels Sep 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix is live in the last release Please download /build the last release and try to reproduce. new Feature New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants