Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doc Editing #2097

Closed
wants to merge 4 commits into from
Closed

Doc Editing #2097

wants to merge 4 commits into from

Conversation

blex-max
Copy link

If you're happy with my style of writing, I will get to work elsewhere. Let me know!

@supermerill
Copy link
Owner

thanks.
just two things:

  • i wouldn't say "strange" but "undesirable"
  • you wrote indicates the number of layers between the inside of the part and the air but if there are layers but no perimeters, it won't be evicted. Same if there is a mix. It's to avoid removing needed bottom layers, and only suppressing the ones that are "disconnected" and so only "over perimeters". But maybe it's an unavoidable simplification?

@blex-max
Copy link
Author

i) agreed, changed to undesirable
ii) I think it's a simplification that adds clarity and the context indicates the rest

@supermerill
Copy link
Owner

merged in my upcoming tooltip udpate commit.

DzzD pushed a commit to DzzD/SuperSlicer that referenced this pull request Dec 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants