Automatic dense infill in large areas falls back to the Enlarge rather than being omitted altogether (Fixes #928) #930
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixing up Visual Studio 2019 build steps as they were missing a few steps that caused issues during building. Ref: prusa3d#3743. Also moved the current step-by-step instructions to the top of the page and left the older/outdated instructions for reference purposes at the bottom as they still contain some useful details.
…unt. Min 7 items and max 15 items
…bjects with modifiers...
…MM-printer profile and extruder colors is set to the filament colors + Fixed a bug with updating colors in extruder editors in ObjectList, when we use filaments colors for extruders and some filament profile is switched
… comboboxes on a sidebar
…rusa3d#5542 Also it likely fixes Crashes when started from symbolic link prusa3d#5751
Updating the Russian translation PrusaSlicer-2.3.0-rc3 by Andylg
Fixed parsing of Point3, fortunately Point3 was used at just a single command line parameter, thus this was not a big deal.
Update How to build - Windows.md
…Slicer source tree.
with an updated Xcode / clang incorrectly reporting that it supports __cpp_lib_uncaught_exceptions while it does not if targeting older platforms. This issue has been fixed in boost 1.74.0 and 1.75.0
…rusa3d#5813) Don't use if (ptr) delete ptr; call delete ptr; directly, it contains the test for null ptr.
Importing a config bundle as a config file was broken for multi material FDM printers, where a different filament was active for each extruder.
…y is provided. This was broken between 2.2.0 and 2.3.0 (1bffc2b) and changed the CLI behaviour. Also related to 5029.
(deriving the printer technology from the merged configs).
Set the printer_technology field.
an update of wxWidgets, which do not compile cleanly on 10.9 without further patching.
fixing "percent first layer speed was not applied over autospeed." GH upstream Slic3r prusa3d#2945 our GH issue First Layer Speed Percentage not applying (prusa3d#5829)
where we have issues with false positives of address sanitizer https://github.com/google/sanitizers/wiki/AddressSanitizerContainerOverflow#false-positives Setting ASAN_OPTIONS=detect_container_overflow=0 inside Info.plist
Fixed extrusion width validation logic in case the extrusion width was specified wrt. layer height.
…ed on Manipulation panel for coordinate space choice now. + Fix of warning on wxBitmap.SetWidth(): deleted meaningless from wxWidgets 3.0 code
(wxWidgets 3.1.4 can binding of wxEVT_DPI_CHANGED now, so it was called msw_rescale() for most of the controls redundantly) + Fixed update of the DoubleSlider after changing of the system color
…lgorithm rather than being omitted altogether (Fixes supermerill#928)
|
merged |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See issue #928 for details of the issue.
This PR resolves it. Tested manually on the attachment in that issue. Unit tests don't seem to compile at head, so those haven't been run.
Note that there seems to be some nondeterminism with placement of dense infill layers, but that exists both before and after this PR.