[feature] Start implementing refetch of lost media files via /api/v1/admin/media_refetch
#1221
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tsmethurst
changed the title
/api/v1/admin/media_refetch
tsmethurst
changed the title
/api/v1/admin/media_refetch/api/v1/admin/media_refetch
- change/fix log levels - make sure not to try to refetch local emojis - small style refactoring + comments
|
Fixed 'er up a bit :) |
|
Once you've fixed that above unresolved comment you can go ahead and merge this, otherwise looks great :) |
Signed-off-by: kim <grufwub@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds an api endpoint
/api/v1/admin/media_refetchwhich acceptsPOSTrequests from instance admins.On successful
POST, this triggers a process in the media manager which iterates through media entries in the database, and for each item checks whether an entry for that item exists in storage. If it doesn't, it will be refetched by making a call to a remote instance, and stored if possible.This is intended for scenarios where you've accidentally deleted items from your storage directory, and you want to recover them without having to take painstaking repetitive manual actions.
The
POSTrequest accepts a query parameter,domain, which can be used to specify the domain that the instance should check media from. This defaults to all domains.The PR is tested + working on goblin.technology where I, guess what, accidentally deleted some emojis from storage :')
currently this only implements refetching of emojis!