Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Apache docs to use 127.0.0.1 instead of localhost #1266

Merged
merged 2 commits into from
Dec 15, 2022

Conversation

EchedelleLR
Copy link
Contributor

@EchedelleLR EchedelleLR commented Dec 14, 2022

Description

Update Apache docs to use 127.0.0.1 instead of localhost as done with Nginx at #1264.

Checklist

If this is a documentation change, only the first checkbox must be filled (you can delete the others if you want).

  • I we have read the GoToSocial contribution guidelines.
  • I we have discussed the proposed changes already, either in an issue on the repository, or in the Matrix chat.
  • I we have performed a self-review of added code.
  • I we have written code that is legible and maintainable by others.
  • I we have commented the added code, particularly in hard-to-understand areas.
  • I we have made any necessary changes to documentation.

Copy link
Contributor

@igalic igalic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks! here's some feedback

@igalic
Copy link
Contributor

igalic commented Dec 14, 2022

thanks! here's some feedback

Well that didn't work

@EchedelleLR
Copy link
Contributor Author

Did I make something wrong? I cannot see the proposed changes.

Copy link
Contributor

@igalic igalic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

after rereading your patch, and the documentation, I've come to the conclusion that there's nothing to improve on here!

@tsmethurst
Copy link
Contributor

Thanks for this :)

@tsmethurst tsmethurst merged commit bae7398 into superseriousbusiness:main Dec 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants