-
-
Notifications
You must be signed in to change notification settings - Fork 351
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[performance] media processing improvements #1288
[performance] media processing improvements #1288
Conversation
Still reviewing but it looks good so far. Does it make sense to try to include #1295 in this, or should that be a separate PR? Either is OK imo |
it might as well be included in this PR tbh :) |
e2f0d3c
to
b7371e0
Compare
…ired syscalls Signed-off-by: kim <grufwub@gmail.com>
… improved media processing AlreadyExists error handling Signed-off-by: kim <grufwub@gmail.com>
Signed-off-by: kim <grufwub@gmail.com>
Signed-off-by: kim <grufwub@gmail.com>
Signed-off-by: kim <grufwub@gmail.com>
Signed-off-by: kim <grufwub@gmail.com>
Signed-off-by: kim <grufwub@gmail.com>
Signed-off-by: kim <grufwub@gmail.com>
Signed-off-by: kim <grufwub@gmail.com>
b7371e0
to
89df54b
Compare
Signed-off-by: kim <grufwub@gmail.com>
Signed-off-by: kim <grufwub@gmail.com>
Signed-off-by: kim <grufwub@gmail.com>
Signed-off-by: kim <grufwub@gmail.com>
Signed-off-by: kim <grufwub@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks fucking great in general. I have a few small comments, but this seems more or less ready to merge, to me. Thanks for your hard work on this!! <3
Signed-off-by: kim <grufwub@gmail.com>
Signed-off-by: kim <grufwub@gmail.com>
Signed-off-by: kim <grufwub@gmail.com>
Signed-off-by: kim <grufwub@gmail.com>
Description
go-store
andgo-cache
versionsgtsImage{}
andgtsVideo{}
types for neatnessChecklist
go fmt ./...
andgolangci-lint run
.