-
-
Notifications
You must be signed in to change notification settings - Fork 349
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[frogend] Settings refactor #1318
Conversation
Love how this is coming along, it looks a lot neater and easier to reason about! |
5ae77da
to
a4f0fb9
Compare
oh mannnnnn it's coming along, i'm excited 👀 |
All main goals are finished now, will review the CSS tomorrow and it can use some more testing! |
fixes #1253 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Phew! Okay, it looks good! I have some comments as you can see, but they're mostly like 'nice' and small questions. I don't see anything here that gave me pause. Great work f0x! Feel free to merge it whenever you're ready :)
Progress towards refactoring the settings interface, almost finished now.
The codebase has grown kind of organically over time, writing newer/better ways to do things but not reflecting them in the existing sections. Most importantly this includes the use of RTK Query, and various refactors of the form field structure I yakshaved.
I'm standardizing on RTK Query everywhere, and self-designed form api/components that have a flexible hook structure to hold their data so they can be used in specialized usecases, or with a set of standardized form components in various types usage.
Goals:
NLnet Milestone 16: Settings interface refactor