[chore/bugfix] Serve + throttle publickey separately from rest of ActivityPub API #1461
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request updates some of our routing code to serve the
/users/:username/main-key
ActivityPub endpoint separately from the other AP endpoints, in order to apply separate throttling + cache policies on it (public cache with lengthy max-age).The reason for this change is that when a status is federated from GtS to a Mastodon server, Mastodon always makes a request to get the main-key again (mastodon/mastodon#19217). If it can't get the main-key because of throttling or some other issue, the status won't be accepted by that Mastodon server, leading to spotty federation.
By throttling the main key separately from other AP endpoints, there should be less chance of a post not federating to mastodon due to server unavailability.
Finally, the PR also includes changes to the nginx advanced documentation, to provide the option of allowing nginx to cache main-key responses in addition to webfinger responses.
Checklist
Please put an x inside each checkbox to indicate that you've read and followed it:
[ ]
->[x]
If this is a documentation change, only the first checkbox must be filled (you can delete the others if you want).
go fmt ./...
andgolangci-lint run
.