-
-
Notifications
You must be signed in to change notification settings - Fork 356
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[chore] small changes missed in previous dereferencer.GetAccount() PRs #1467
Merged
NyaaaWhatsUpDoc
merged 5 commits into
superseriousbusiness:main
from
NyaaaWhatsUpDoc:chore/small-changes-to-previous-prs
Feb 10, 2023
Merged
Changes from 4 commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
61331b7
small formatting changes, rewrite fetchRemoteMedia to use separate fu…
NyaaaWhatsUpDoc dad1036
move url parsing before acquiring mutex locks
NyaaaWhatsUpDoc c65a2a0
use wrapped mutexes to allow safe unlocking. (previously i did a fuck…
NyaaaWhatsUpDoc c9ab4d0
remove unused code
NyaaaWhatsUpDoc 117b37e
use consistent map keying for dereferencing headers/avatars
NyaaaWhatsUpDoc File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perhaps before returning, it's worth calling
processing.LoadAttachment
to make sure that the attachment will really be in the database for the caller to select with the ID; it's idempotent anyway I think so it should be fine.