Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature] About page #1495

Merged
merged 3 commits into from
Feb 20, 2023
Merged

[feature] About page #1495

merged 3 commits into from
Feb 20, 2023

Conversation

f0x52
Copy link
Contributor

@f0x52 f0x52 commented Feb 13, 2023

Description

Basic /about page, using the full instance description and generating some more info from various settings. Also links to /about/suspended if enabled.

image

Checklist

  • I/we have read the GoToSocial contribution guidelines.
  • I/we have discussed the proposed changes already, either in an issue on the repository, or in the Matrix chat.
  • I/we have performed a self-review of added code.
  • I/we have written code that is legible and maintainable by others.
  • I/we have commented the added code, particularly in hard-to-understand areas.
  • I/we have made any necessary changes to documentation.
  • I/we have added tests that cover new code.
  • I/we have run tests and they pass locally with the changes.
  • I/we have run go fmt ./... and golangci-lint run.

@f0x52
Copy link
Contributor Author

f0x52 commented Feb 15, 2023

I think this will serve as a decent base combining the editable long description with some auto-generated info about the settings, but should be override-able when we get more generic 'instance pages' support (#881)

@f0x52
Copy link
Contributor Author

f0x52 commented Feb 15, 2023

something to fix: custom emoji are displayed way too big in the contact card :")
image

@tsmethurst
Copy link
Contributor

Should i merge this now and we can fix the emoji stuff in a separate patch? or do you wanna do it in this PR?

@f0x52
Copy link
Contributor Author

f0x52 commented Feb 17, 2023

might as well wait with merging till it's fixed I think, should be soon(tm)

@tsmethurst tsmethurst merged commit b6143c9 into main Feb 20, 2023
@tsmethurst tsmethurst deleted the about-page branch February 20, 2023 15:29
@xmgz
Copy link
Contributor

xmgz commented Apr 13, 2023

Excuse me, may I propose an enhacement here? I think it's the right place.

wouldn't it be good have a direct link to "/about" in the profile/user-TL page footer? As it happens with "contact" and "instance version". Otherwise this About page is hidden without public links (as far as I'd seen) for casual visitiors.

Having markdown for the long instance description would also help, adding some formatting. In my opinion.

thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants