Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add sqlite support #154

Closed
wants to merge 26 commits into from
Closed

Add sqlite support #154

wants to merge 26 commits into from

Conversation

NyaaaWhatsUpDoc
Copy link
Member

No description provided.

@NyaaaWhatsUpDoc
Improved build script
9e1673d 
- explicity disable cgo
- ensure static builds
- reduce binary size
- small formatting changes

Signed-off-by: kim (grufwub) <grufwub@gmail.com>
@NyaaaWhatsUpDoc
add initial sqlite support, add modernc.org/sqlite to vendored libs
cec939f 
Signed-off-by: kim (grufwub) <grufwub@gmail.com>
@NyaaaWhatsUpDoc
Update DB configuration to mention new sqlite options
3651516 
Signed-off-by: kim (grufwub) <grufwub@gmail.com>
@NyaaaWhatsUpDoc
Merge branch 'main' into feature/add-sqlite-support
e9de6a2
tsmethurst
tsmethurst reviewed Aug 26, 2021
View reviewed changes
internal/db/bundb/bundb.go Outdated Show resolved Hide resolved
go.mod Show resolved Hide resolved
@NyaaaWhatsUpDoc
add licenses to README
4ed4486 
Signed-off-by: kim (grufwub) <grufwub@gmail.com>
@NyaaaWhatsUpDoc
return error instead of panic on sql.Open("sqlite")
5747af9 
Signed-off-by: kim (grufwub) <grufwub@gmail.com>
@NyaaaWhatsUpDoc
improve formatting of new licenses
fc561ef 
Signed-off-by: kim (grufwub) <grufwub@gmail.com>
@NyaaaWhatsUpDoc
Copy link
Member Author

Warning: this is definitely not in a working state

@NyaaaWhatsUpDoc
wrap bun.DB in dbConn for dbconn specific error processing etc
0000c2c 
Signed-off-by: kim (grufwub) <grufwub@gmail.com>
@NyaaaWhatsUpDoc
fix catching wrong error... add code comments
1a82872 
Signed-off-by: kim (grufwub) <grufwub@gmail.com>
@NyaaaWhatsUpDoc
remove unneeded nested sprintf within debugf
0bc538b 
Signed-off-by: kim (grufwub) <grufwub@gmail.com>
@NyaaaWhatsUpDoc
Merge remote-tracking branch 'upstream/main' into feature/add-sqlite-…
63412d5 
…support

Signed-off-by: kim (grufwub) <grufwub@gmail.com>
@NyaaaWhatsUpDoc
Merge remote-tracking branch 'upstream/main' into feature/add-sqlite-…
5809ded 
…support

Signed-off-by: kim (grufwub) <grufwub@gmail.com>
@NyaaaWhatsUpDoc NyaaaWhatsUpDoc mentioned this pull request Aug 26, 2021
Closed
@NyaaaWhatsUpDoc
ensure ,notnull,nullzero on all columns with default values
77a5785 
Signed-off-by: kim (grufwub) <grufwub@gmail.com>
@NyaaaWhatsUpDoc
Merge remote-tracking branch 'upstream/main' into feature/add-sqlite-…
4b26b11 
…support
@NyaaaWhatsUpDoc
Merge remote-tracking branch 'upstream/main' into feature/add-sqlite-…
b654a12 
…support
@NyaaaWhatsUpDoc
fix returning nil error processing sqlite errors
718503e 
Signed-off-by: kim (grufwub) <grufwub@gmail.com>
@NyaaaWhatsUpDoc
remove unnecessary notnulls
850c564 
Signed-off-by: kim (grufwub) <grufwub@gmail.com>
@NyaaaWhatsUpDoc
use more SQL-implementation agnostic query
9d8faa4 
Signed-off-by: kim (grufwub) <grufwub@gmail.com>
@NyaaaWhatsUpDoc
Fix possible issue on db.ErrNoEntries AND non-zero query count
57ccbb9 
Signed-off-by: kim (grufwub) <grufwub@gmail.com>
@NyaaaWhatsUpDoc
slightly improved mentiondb err handling
5c9d9e1 
Signed-off-by: kim (grufwub) <grufwub@gmail.com>
@NyaaaWhatsUpDoc
fix ptr being incorrectly assigned to
26887b3 
Signed-off-by: kim (grufwub) <grufwub@gmail.com>
@NyaaaWhatsUpDoc
Merge branch 'bugfix/status-mention-population' into feature/add-sqli…
25af975 
…te-support
@NyaaaWhatsUpDoc
Copy link
Member Author

NyaaaWhatsUpDoc commented Aug 27, 2021 •
edited
Loading

TODO: add SQLite default test config to also be tested, there may be some constraint related tests failing -- i think the errors are not being processed and caught correctly?

caught the unprocessed errors

@NyaaaWhatsUpDoc
fix basicDB.Put() to properly process error
b09f20c 
Signed-off-by: kim (grufwub) <grufwub@gmail.com>
@NyaaaWhatsUpDoc
Copy link
Member Author

NyaaaWhatsUpDoc commented Aug 27, 2021 •
edited
Loading

Possibly an issue with accounts being stored as locked by default. Likely fixed by the below commit

@NyaaaWhatsUpDoc
only use nullzero if string/timme.Time
8c5a906 
Signed-off-by: kim (grufwub) <grufwub@gmail.com>
@NyaaaWhatsUpDoc
fix new tx within tx
aef516e 
Signed-off-by: kim (grufwub) <grufwub@gmail.com>
@NyaaaWhatsUpDoc
Merge branch 'bugfix/tx-within-tx' into feature/add-sqlite-support
381f830 
Signed-off-by: kim (grufwub) <grufwub@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tsmethurst tsmethurst tsmethurst left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@NyaaaWhatsUpDoc @tsmethurst