Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bugfix] Add proper constraints on status faves, dedupe #1674

Merged
merged 2 commits into from
Apr 5, 2023

Conversation

tsmethurst
Copy link
Contributor

Description

If this is a code change, please include a summary of what you've coded, and link to the issue(s) it closes/implements.

If this is a documentation change, please briefly describe what you've changed and why.

This pull request:

  • Introduces proper constraints on status faves -- now, an account can only like a status once.
  • Includes a migration to delete duplicate status faves, before adding constraints to status fave table.
  • Implements federating undo logic for status likes -- we didn't have this before for some reason???
  • Does some v. small tidying up in the bits of the codebase that had to be touched ✋

Checklist

Please put an x inside each checkbox to indicate that you've read and followed it: [ ] -> [x]

If this is a documentation change, only the first checkbox must be filled (you can delete the others if you want).

  • I/we have read the GoToSocial contribution guidelines.
  • I/we have discussed the proposed changes already, either in an issue on the repository, or in the Matrix chat.
  • I/we have performed a self-review of added code.
  • I/we have written code that is legible and maintainable by others.
  • I/we have commented the added code, particularly in hard-to-understand areas.
  • I/we have made any necessary changes to documentation.
  • I/we have added tests that cover new code. -- tested the migration on both sqlite and postgres, seems OK
  • I/we have run tests and they pass locally with the changes.
  • I/we have run go fmt ./... and golangci-lint run.

@tsmethurst tsmethurst force-pushed the status_fave_unique_constraints branch from 5d50233 to ce03ba4 Compare April 5, 2023 17:55
@tsmethurst tsmethurst merged commit 8d2a76c into main Apr 5, 2023
@tsmethurst tsmethurst deleted the status_fave_unique_constraints branch April 5, 2023 18:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant